Update deployment.rst #9443
Merged
Update deployment.rst #9443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix 404 not found the link was: - http://api.symfony.com/3.4/Symfony/Component/HttpKernel/Kernel/Kernel.html#method_getProjectDir> (404) And I tried to make it like this: -http://api.symfony.com/3.4/Symfony/Component/HttpKernel/Kernel.html#method_getProjectDir (working) But since I don't know how links are generated from the doc I guess that removing the useless "Kernel" and ">" can do the job.
|
@bricelalu good catch! Thanks for fixing this wrong link. If you are curious, those links are generated automatically when parsing the docs using this code: https://github.com/fabpot/sphinx-php/blob/e0472cd05ab96eebbf3a96cdacaf2edd57fb018f/sensio/sphinx/phpcode.py#L145-L150 |
javiereguiluz
added a commit
that referenced
this pull request
Mar 15, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Update deployment.rst Fix 404 not found the link was: - http://api.symfony.com/3.4/Symfony/Component/HttpKernel/Kernel/Kernel.html#method_getProjectDir> (404) And I tried to make it like this: -http://api.symfony.com/3.4/Symfony/Component/HttpKernel/Kernel.html#method_getProjectDir (working) But since I don't know how links are generated from the doc I guess that removing the useless "Kernel" and ">" can do the job. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- c9f0976 Update deployment.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 404 not found
the link was:
And I tried to make it like this:
-http://api.symfony.com/3.4/Symfony/Component/HttpKernel/Kernel.html#method_getProjectDir (working)
But since I don't know how links are generated from the doc I guess that removing the useless "Kernel" and ">" can do the job.